fix(desktop): settle channel opens at latest message#2846
Closed
wesbillman wants to merge 2 commits into
Closed
Conversation
Wait for the virtualized timeline API before consuming initial channel positioning, and do not mistake measurement-driven offsets for reader input while the virtualizer is settling at the floor. Co-authored-by: Carl <c7ebe626f000404285d3686e1dc74cc07cc60a9754a150041ba132e14bd3e2ec@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
Replace the timeout-based bottom chase with explicit bottom intent driven by Virtua content and viewport geometry. Reader navigation, targeted messages, and history prepends still take ownership immediately, while late row reflow and composer typing no longer strand the timeline above its newest message. Co-authored-by: Carl <c7ebe626f000404285d3686e1dc74cc07cc60a9754a150041ba132e14bd3e2ec@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
wesbillman
force-pushed
the
carl/fix-channel-open-bottom
branch
from
July 25, 2026 15:10
fa0ce9c to
1db6b01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Normal channel opens are intended to show the latest message. During a keyed channel remount, the parent could mark initial positioning complete before Virtua registered its inner scroller API. Virtua's own fallback settle could then cancel itself on an intermediate measurement offset, leaving the newest message hidden.
Verification
pnpm exec biome check src/features/messages/ui/TimelineMessageList.tsx src/features/messages/ui/useAnchoredScroll.ts tests/e2e/scroll-history.spec.tspnpm typecheck