Skip to content

Remove incomplete tss keychain backup option#4119

Merged
kajoseph merged 3 commits intobitpay:masterfrom
kajoseph:rmTssKeyBackup
Mar 11, 2026
Merged

Remove incomplete tss keychain backup option#4119
kajoseph merged 3 commits intobitpay:masterfrom
kajoseph:rmTssKeyBackup

Conversation

@kajoseph
Copy link
Copy Markdown
Collaborator

@kajoseph kajoseph commented Mar 10, 2026

Description

The backup keyshare to our server needs more thought and consideration. It was a consideration in our prototype with the idea to make restoring from just 12 words easier. Removing for now.

Changelog

  • Quietly removes key backup saving logic.
  • Remove the backupKeyShare option from the tsskey class in BWC.

Testing Notes

Pretty straight forward.


Checklist

  • I have read CONTRIBUTING.md and verified that this PR follows the guidelines and requirements outlined in it.
  • I have added the appropriate package tag(s) (e.g. BWC if modifying the bitcore-wallet-client package, CLI if modifying the bitcore-cli package, etc.)
  • I have verified that this is not an existing PR (open or closed)

@kajoseph kajoseph added BWC This pull request modifies the bitcore-wallet-client package BWS This pull request modifies the bitcore-wallet-service package labels Mar 10, 2026
@kajoseph kajoseph merged commit d942ad5 into bitpay:master Mar 11, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BWC This pull request modifies the bitcore-wallet-client package BWS This pull request modifies the bitcore-wallet-service package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants