Add two Aave endpoints to get reserve data and reserve token addresses#4112
Merged
kajoseph merged 3 commits intobitpay:masterfrom Mar 11, 2026
Merged
Conversation
leolambo
reviewed
Feb 26, 2026
Comment on lines
+129
to
+141
| const requestedVersion = String(req.query.version || 'v3').toLowerCase(); | ||
| if (!isAaveVersion(requestedVersion)) { | ||
| res.status(400).send('Unsupported Aave version'); | ||
| return; | ||
| } | ||
| if (!getAavePoolAddress(this.chain, network, requestedVersion)) { | ||
| res.status(400).send('Unsupported chain or network for Aave'); | ||
| return; | ||
| } | ||
| if (!Web3.utils.isAddress(asset)) { | ||
| res.status(400).send('Invalid address'); | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
this is essentially repeated across here, getAaveReserveTokensAddresses and getAaveUserAccountData. code can be DRY'd up with a helper function like validateAaveRequest
Contributor
Author
There was a problem hiding this comment.
Added a centralized helper function to validate the request.
kajoseph
requested changes
Mar 10, 2026
Collaborator
kajoseph
left a comment
kajoseph
left a comment
There was a problem hiding this comment.
There are a few linting errors here. TBH, I'm not sure how you were able to bypass the precommit lint check. npm run lint from the bitcore-node module should show you what needs to be fixed - mostly string double quotes in aavePool.ts and aavePoolV2.ts. Otherwise, I'm good to approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added two new endpoints to get reserve data and reserve token addresses from Aave.
Changelog
Testing Notes
I made a script to call both endpoints across multiple chains/versions with USDC addresses.
Checklist
BWCif modifying the bitcore-wallet-client package,CLIif modifying the bitcore-cli package, etc.)