fix reqresp status_now peer resolution#152
Merged
bitmine-mihir merged 1 commit intoJul 13, 2026
Merged
Conversation
Contributor
|
Thanks for the PR @bomanaps! I have reviewed it and will merge it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request_status_now was passing NULL for the struct peer ID when the caller only had text, so service_open_exchange rejected the call and 96% of periodic status requests silently failed with -1004. I resolve the peer ID from the text via lantern_peer_id_from_text before the call same pattern already in client_reqresp_blocks.c:33.