Skip to content

[backport] deps: bump webpki-roots to 1.0.10 - #234

Merged
oleonardolima merged 4 commits into
bitcoindevkit:release/0.24.xfrom
oleonardolima:backport/pr-231
Oct 21, 2026
Merged

oleonardolima merged 4 commits into
bitcoindevkit:release/0.24.xfrom
oleonardolima:backport/pr-231

Conversation

@oleonardolima

Copy link
Copy Markdown
Contributor
  • bump webpki-roots from 0.25 to 1.0.10 in Cargo.toml
  • build RootCertStore from TLS_SERVER_ROOTS.to_vec() now that the roots are already rustls_pki_types::TrustAnchor values, replacing the manual Der::from_slice field mapping
  • drop the now-unused Der and TrustAnchor imports from raw_client
  • keep this line's use-rustls/use-rustls-ring/use-openssl #[cfg] on the rustls import

fixes #230

(cherry picked from commit ee435a0)

@oleonardolima
oleonardolima marked this pull request as ready for review October 21, 2026 21:04
@oleonardolima oleonardolima self-assigned this Oct 21, 2026
oleonardolima and others added 4 commits October 21, 2026 16:35
- bump `webpki-roots` from `0.25` to `1.0.10` in `Cargo.toml`
- build `RootCertStore` from `TLS_SERVER_ROOTS.to_vec()` now that the
  roots are already `rustls_pki_types::TrustAnchor` values, replacing
  the manual `Der::from_slice` field mapping
- drop the now-unused `Der` and `TrustAnchor` imports from `raw_client`
- keep this line's `use-rustls`/`use-rustls-ring`/`use-openssl` `#[cfg]`
  on the `rustls` import

fixes bitcoindevkit#230

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
(cherry picked from commit ee435a0)
Signed-off-by: Leonardo Lima <oleonardolima@users.noreply.github.com>
- add a "Pin dependencies for MSRV" step to the `1.75.0` test job that
  pins `openssl` to `0.10.78`, `openssl-sys` to `0.9.114`, `zeroize` to
  `1.8.2` and `jobserver` to `0.1.34`, since newer releases require
  `edition2024` and fail to resolve on the MSRV toolchain
- document the MSRV pins in the README

(cherry picked from commit 6f300fe)
(cherry picked from commit 1ca8828)
(cherry picked from commit 6e8ee69)

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Leonardo Lima <oleonardolima@users.noreply.github.com>
- replace the archived `actions-rs/clippy-check@v1` action with a plain
  `cargo clippy --all-features --all-targets -- -D warnings` step, as it
  fails to create check annotations on pull requests from forks
- use `dtolnay/rust-toolchain@v1` for the clippy job
- pin `openssl`, `openssl-sys`, `zeroize` and `jobserver` before running
  clippy, since `cargo` `1.84.0` cannot resolve newer releases that
  require `edition2024`

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Leonardo Lima <oleonardolima@users.noreply.github.com>
- drop the `Swatinem/rust-cache@v2.2.1` step, which fails to restore
  with "Cache service responded with 400" on the deprecated cache API,
  and rely on `dtolnay/rust-toolchain` alone

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Leonardo Lima <oleonardolima@users.noreply.github.com>
@oleonardolima oleonardolima added the bug Something isn't working label Oct 21, 2026
@oleonardolima

Copy link
Copy Markdown
Contributor Author

I'm backport the #231 as electrum-client v0.24.x is the one being used by bdk_chain 0.23.x.

@oleonardolima oleonardolima changed the title deps: bump webpki-roots to 1.0.10 [backport] deps: bump webpki-roots to 1.0.10 Oct 21, 2026

@luisschwab luisschwab left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1e8a7f7

@oleonardolima
oleonardolima merged commit 0eebbdb into bitcoindevkit:release/0.24.x Oct 21, 2026
4 checks passed
@oleonardolima
oleonardolima deleted the backport/pr-231 branch October 21, 2026 23:58
oleonardolima added a commit that referenced this pull request Oct 22, 2026
10ad64c chore(release): bump electrum-client to 0.24.2 (Leonardo Lima)

Pull request description:

  depends on #234

ACKs for top commit:
  luisschwab:
    ACK 10ad64c

Tree-SHA512: 90154778dd8e95949ce5d50fa457544e0862aeb6b8525116965c2e971b2be121bc19d4f9d89437601a662fce2723339119c70f74ed24624ff407adba87d86825
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants