Skip to content

Comments

Support Icons#138

Open
clarasb wants to merge 7 commits intomainfrom
clarasb-124-support_icons
Open

Support Icons#138
clarasb wants to merge 7 commits intomainfrom
clarasb-124-support_icons

Conversation

@clarasb
Copy link
Collaborator

@clarasb clarasb commented Feb 10, 2026

This PR adds icon support for the Button, IconButton and Tabs components by,

  • adding an Iconcomponent with the property iconName. iconName has to be a string that corresponds with the names of the Material Icons. For the component the fontFamiliy is set to Material Icons
  • integrating the Icon component into Button, IconButton and Tabs

Other changes:

  • in chartlets.py/chartlets/components/button.py: Added size and removed variant property from IconButton
    component to align with component in chartlets.js.
  • in chartlets.js/packages/demo/packages.json added "@fontsource/material-icons": "^5.1.1" to devDependencies to make icons available in Demo

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.22%. Comparing base (c707e53) to head (577b134).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #138   +/-   ##
=======================================
  Coverage   92.21%   92.22%           
=======================================
  Files          86       87    +1     
  Lines        1503     1504    +1     
  Branches      231      231           
=======================================
+ Hits         1386     1387    +1     
  Misses         98       98           
  Partials       19       19           
Flag Coverage Δ
backend 100.00% <100.00%> (ø)
frontend 83.92% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@clarasb clarasb marked this pull request as ready for review February 20, 2026 09:13
@clarasb clarasb requested review from b-yogesh and forman February 20, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant