fix(BOP-506): remove dead TransferredFromSeizable event from frozen IB20V1 ABI - #4315
Open
rayyan224 wants to merge 2 commits into
Open
fix(BOP-506): remove dead TransferredFromSeizable event from frozen IB20V1 ABI#4315rayyan224 wants to merge 2 commits into
rayyan224 wants to merge 2 commits into
Conversation
…B20V1 ABI Audit finding I-02: the frozen IB20V1 wire surface declared TransferredFromSeizable, which was never part of the v1.1.1 / base-std Beryl surface and has no emit site. Seize logging on V2 emits Seized instead. Update the pinned V1 ABI fingerprint to match the corrected event set. Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
✅ Heimdall Review Status
|
Contributor
|
No issues found. The change is clean and correct:
|
stephancill
approved these changes
Aug 7, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IB20V1ABI declaredTransferredFromSeizable, which was never part of the v1.1.1 / base-std Beryl surface and has no emit site on the V1 path. Seize logging on V2 emitsSeizedinstead.crates/common/precompiles/src/common/abi/v1.rs.V1_ABI_FINGERPRINTincrates/common/precompiles/src/common/abi/v2.rsto match the corrected event set.Confirmed via grep that
TransferredFromSeizablehad no emit site or decode-path reference anywhere in the crate before removal, so this does not change any historical returndata/log output.Linear: https://linear.app/coinbase/issue/BOP-506
Test plan
cargo test -p base-common-precompiles --lib— 648 passedcargo test -p base-common-precompiles --features test-utils --test b20_asset_v1_golden --test b20_stablecoin_v1_golden --test b20_asset_v2_golden --test b20_policy_v1_golden --test b20_factory_v1_golden— 369 passedcargo clippy -p base-common-precompiles --lib --features test-utils -- -D warnings— clean