Add evidence-first prompt outputs#122
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces an “evidence-first” output contract for MAP’s highest-risk workflows (review, debug, plan) by adding a shared reference of compact JSON examples and wiring skill prompts/tests to require quoted evidence before high-impact judgments (verdicts, root causes, risk levels, scores, decomposition boundaries).
Changes:
- Added shared evidence-first JSON output examples and linked them from
/map-review,/map-debug, and/map-planskill prompts. - Added regression tests to enforce evidence-first requirements and ensure shared reference files are byte-for-byte synced into shipped templates.
- Updated docs and improvement-plan ledger entries to reflect the shipped behavior and split generic linting into follow-up
2604.027-1.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_template_sync.py | Adds sync regression coverage for .claude/references/ → templates/references/. |
| tests/test_skills.py | Adds prompt-contract regression tests requiring evidence-first terms + shared examples coverage. |
| src/mapify_cli/templates/skills/map-review/SKILL.md | Requires evidence[] before verdict/risk/score outputs and links shared examples (shipped template). |
| src/mapify_cli/templates/skills/map-debug/SKILL.md | Requires quoted logs/tests/code before root-cause/verdict/risk/score outputs and links shared examples (shipped template). |
| src/mapify_cli/templates/skills/map-plan/SKILL.md | Requires evidence-first spec review + decomposition evidence before subtasks and links shared examples (shipped template). |
| src/mapify_cli/templates/references/map-output-examples.md | Adds the shipped “Evidence-First Output Examples” reference file. |
| .claude/skills/map-review/SKILL.md | Mirrors evidence-first prompt contract updates in source-of-truth skill. |
| .claude/skills/map-debug/SKILL.md | Mirrors evidence-first prompt contract updates in source-of-truth skill. |
| .claude/skills/map-plan/SKILL.md | Mirrors evidence-first prompt contract updates in source-of-truth skill. |
| .claude/references/map-output-examples.md | Adds the source-of-truth evidence-first examples reference file. |
| docs/USAGE.md | Documents evidence-first reviewer/debug/plan output behavior for users. |
| docs/ARCHITECTURE.md | Documents evidence-first root-cause/validation and review contracts in architecture narrative. |
| docs/learned/testing-strategies.md | Records learned testing strategy: sync shared references, not just skills. |
| docs/learned/review-checks.md | Records learned review check about separating shipped prompt behavior vs lint tooling scope. |
| docs/learned/commands.md | Records learned command workflow: smoke generated evidence references via mapify init. |
| docs/improvement-plan.md | Moves 2604.027 lint tooling into new follow-up 2604.027-1 and clarifies shipped scope. |
| docs/improvement-loop-log.md | Logs closure of 2604.027 with validation notes and follow-up split. |
| docs/improvement-done.md | Marks 2604.027 as done with explicit shipped evidence-first slice summary. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Follow-up