Skip to content

Close shipped LEARN ergonomics plan item#121

Merged
azalio merged 1 commit into
mainfrom
codex/2604-035-close-learn-parent
May 17, 2026
Merged

Close shipped LEARN ergonomics plan item#121
azalio merged 1 commit into
mainfrom
codex/2604-035-close-learn-parent

Conversation

@azalio
Copy link
Copy Markdown
Owner

@azalio azalio commented May 17, 2026

Summary

  • remove stale active parent item 2604.035 from docs/improvement-plan.md
  • record the parent closure in docs/improvement-done.md with shipped child-slice evidence
  • add loop log and learned review check for closing completed umbrella parents

Validation

  • python /Users/azalio/.config/opencode/skills/improvement-plan-loop/scripts/idea_index.py .
  • pytest tests/test_map_step_runner.py::test_write_learning_handoff_creates_artifacts_and_manifest tests/test_map_step_runner.py::test_write_learning_handoff_records_repeated_rule_violations tests/test_map_step_runner.py::test_map_step_runner_cli_write_learning_handoff_records_repeated_violation_smoke -v
  • python /Users/azalio/.config/opencode/skills/repo-learning-capture/scripts/capture_learning.py --repo . --handoff /var/folders/3j/zmvdy5_56bjcg1kmrx05dltcf7yldq/T/opencode/learning-handoff-2604.035.md
  • git diff --check
  • pytest -m "not slow"

Full pytest was attempted and progressed through deterministic tests plus the first live Claude SDK e2e tests, then exceeded the 15-minute tool timeout at TestMapEfficientE2E::test_efficient_produces_code_changes.

Copilot AI review requested due to automatic review settings May 17, 2026 17:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Closes the stale umbrella improvement-plan item [2604.035] by removing it from the active plan ledger and recording its closure (with shipped child-slice evidence) in the done + loop log docs, preventing future loops from re-selecting already-shipped LEARN ergonomics work.

Changes:

  • Removed the active plan entry [2604.035] from docs/improvement-plan.md.
  • Added a closure record for [2604.035] to docs/improvement-done.md, citing the already-shipped child slices as evidence.
  • Logged the closure decision in docs/improvement-loop-log.md and added a reusable review check in docs/learned/review-checks.md.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
docs/learned/review-checks.md Adds a new review check to close umbrella parents based on shipped child-slice evidence.
docs/improvement-plan.md Removes the stale active umbrella item [2604.035] from the plan ledger.
docs/improvement-loop-log.md Records the closure decision and validation notes for [2604.035].
docs/improvement-done.md Adds a closure record for [2604.035] with repo evidence pointing to shipped child slices.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@azalio azalio merged commit 79633be into main May 17, 2026
10 checks passed
@azalio azalio deleted the codex/2604-035-close-learn-parent branch May 17, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants