Close shipped workflow-fit plan item#118
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR closes a stale workflow-fit improvement-plan item by moving it from the active backlog to the done ledger and recording loop learnings around detecting already-shipped ideas.
Changes:
- Removed
[2604.038]from the active improvement plan. - Added a done-ledger entry with repo evidence for the shipped workflow-fit/off-ramp behavior.
- Added loop-log and learned-command notes for checking stale active ideas before rebuilding them.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docs/learned/commands.md | Adds a reusable command pattern for closing already-shipped active ideas. |
| docs/improvement-plan.md | Removes the stale workflow-fit/off-ramp active plan item. |
| docs/improvement-loop-log.md | Records the loop decision, validation boundary, and reusable learnings. |
| docs/improvement-done.md | Adds [2604.038] to the done ledger with evidence. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - Review Result: Diff review confirmed the change is documentation/ledger-only and does not alter runtime behavior. | ||
| - Next Trigger: Reuse this learning whenever an active plan item references behavior already visible in runtime code, generated templates, docs, and tests. | ||
| - Reusable Learnings: | ||
| - command: `python "/Users/azalio/.config/opencode/skills/improvement-plan-loop/scripts/idea_index.py" .` |
| - **Use non-existent target paths for init smoke tests** (2026-05-15): `mapify init <path>` creates the target directory, so do not pre-create it with `mktemp -d`; pass a unique path under an existing temp parent and then inspect the generated `.claude/` artifacts. [workflow: improvement-plan-loop] | ||
| - **Grep stale skill names during taxonomy changes** (2026-05-15): When skill catalog docs change, search for removed or non-shipped skill names such as `map-workflows-guide` and `map-cli-reference`; generated install smoke tests prove current templates emit metadata, but they do not catch every stale prose reference. [workflow: improvement-plan-loop] | ||
| - **Validate run health reports in CI handoff** (2026-05-16): Use `python3 .map/scripts/map_step_runner.py validate_run_health_report [path]` after `write_run_health_report` when a workflow closeout must fail on schema drift, retry overflow, missing verification evidence, or unexplained hook degradation. [workflow: improvement-plan-loop] | ||
| - **Close already-shipped active ideas with repo evidence** (2026-05-16): Before implementing an active improvement-plan item, run the idea indexer and grep runtime, shipped templates, docs, and tests for the core artifact or route names; if the capability already exists, move the exact `[idea_id]` to done with evidence instead of rebuilding it. [workflow: improvement-plan-loop] |
| - Repo evidence: `.map/scripts/map_step_runner.py` and the shipped template copy define `WORKFLOW_FIT_ROUTES`, persist `.map/<branch>/workflow-fit.json` through `record_workflow_fit`, and mark `direct-edit` as `needs_map=false`. | ||
| - Repo evidence: `src/mapify_cli/schemas.py` includes `WORKFLOW_FIT_DECISION_SCHEMA` with `direct-edit`, `map-fast`, `map-efficient`, `map-tdd`, and `map-plan` routes. | ||
| - Repo evidence: `.claude/skills/map-plan/SKILL.md` and shipped template copies require the workflow-fit gate before planning and explicitly stop on `direct-edit` or `map-fast` off-ramp outcomes. | ||
| - Repo evidence: README, `docs/USAGE.md`, `docs/ARCHITECTURE.md`, `docs/roadmap.md`, and regression/e2e tests already document and validate the off-ramp behavior. |
Owner
Author
|
Addressed Copilot review comments in aacf865:
Local validation after fixes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[2604.038]from the active improvement plan to the done ledger with repo evidence.Validation
python \"/Users/azalio/.config/opencode/skills/improvement-plan-loop/scripts/idea_index.py\" .pytest tests/test_map_step_runner.py::test_record_workflow_fit_creates_decision_and_manifest tests/test_template_sync.py -vmapify init+record_workflow_fit direct-edit ...producedneeds_map=falsemake lintpytest -m \"not slow\"Boundary
pytestwas attempted but exceeded the tool timeout at the live Claude SDKTestMapEfficientE2E::test_efficient_produces_code_changes; the isolated test also exceeded 15 minutes without a deterministic assertion failure.