Skip to content

Remove old interpreted endpoint rules path, merge rules2 into rules, and delete legacy runtime resources - #7269

Open
S-Saranya1 wants to merge 3 commits into
feature/master/use-codegen-rules-by-defaultfrom
somepal/cleanup-remove-compiled-endpoint-rules-flag
Open

Remove old interpreted endpoint rules path, merge rules2 into rules, and delete legacy runtime resources#7269
S-Saranya1 wants to merge 3 commits into
feature/master/use-codegen-rules-by-defaultfrom
somepal/cleanup-remove-compiled-endpoint-rules-flag

Conversation

@S-Saranya1

@S-Saranya1 S-Saranya1 commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Motivation and Context

This PR completes the cleanup for enabling compiled endpoint rules as the only code path. With the flag-flip PR enabling compiled rules for all services, the old interpreted endpoint rules path and the separate rules2 package are no longer needed. This PR removes the legacy code and consolidates everything into a single clean structure.

This PR is part of 3 cleanup PRs:

Modifications

  • Remove the enableGenerateCompiledEndpointRules flag — Delete field, getter, and setter from CustomizationConfig.java
  • Remove if/else branching in EndpointProviderTasks.java — Always use compiled path, remove shouldGenerateCompiledEndpointRules() and generateDefaultProvider() methods
  • Delete old interpreted endpoint provider — Remove EndpointProviderSpec.java (the interpreted code generator)
  • Delete RulesEngineRuntimeLiteGeneratorTask.java and RulesEngineRuntimeGeneratorTask2.java — No longer needed; the base RulesEngineRuntimeGeneratorTask now handles all resource copying
  • Merge rules2/ package into rules/ — Move all files, update package statements, rename EndpointProviderSpec2 → EndpointProviderSpec
  • Delete old interpreted .java.resource files — Remove 54 files (DefaultRuleEngine, RuleEvaluator, Condition, Expr, etc.) that were only used by the interpreted path
  • Delete Arn.java.resource — No longer needed (internal teams will migrate to the public software.amazon.awssdk.arns.Arn)
  • Delete RuleSetCreationSpec.java — Dead code, not referenced anywhere
  • Remove rulesEngineResourceFiles2() from EndpointRulesSpecUtils.java
  • Delete EndpointProviderClassSpecTest.java — Tested the old interpreted provider which no longer exists
  • Move test files and resources from rules2/ to rules/

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@S-Saranya1
S-Saranya1 requested a review from a team as a code owner August 13, 2026 07:22
@S-Saranya1
S-Saranya1 changed the base branch from master to feature/master/use-codegen-rules-by-default August 13, 2026 07:22
@S-Saranya1 S-Saranya1 changed the title Remove old interpreted endpoint rules path, merge rules2 into rules, … Remove old interpreted endpoint rules path, merge rules2 into rules and delete legacy runtime resources Aug 13, 2026
@S-Saranya1 S-Saranya1 changed the title Remove old interpreted endpoint rules path, merge rules2 into rules and delete legacy runtime resources Remove old interpreted endpoint rules path, merge rules2 into rules, and delete legacy runtime resources Aug 17, 2026
@S-Saranya1
S-Saranya1 requested a review from joviegas August 17, 2026 19:20
@S-Saranya1

S-Saranya1 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

note: Builds are failing because this PR depends on the flag-flip PR (#7265) which has the regionId bug fix. Once that's merged first, the builds here will pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants