Skip to content

fix: Bump setuptools to patch CVE-2024-6345 #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sharmabikram merged 3 commits into from
Apr 27, 2026
+6 −4
Merged

fix: Bump setuptools to patch CVE-2024-6345 #828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b663554
fix: Bump setuptools to patch CVE-2024-6345
sharmabikram Apr 24, 2026
a384259
fix: Add dev_requirements to MANIFEST.in
sharmabikram Apr 24, 2026
e1a68ea
fix: Update sdist glob pattern for PEP 625 naming
sharmabikram Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions MANIFEST.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@ recursive-exclude doc .DS_Store *.pyc
prune doc/build
prune doc/lib/generated

recursive-include dev_requirements *
recursive-include test *
recursive-exclude test .DS_Store *.pyc
3 changes: 2 additions & 1 deletion dev_requirements/release-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
pypi-parker==0.1.2
setuptools==66.1.1
setuptools>=75.0
build>=1.0
Comment on lines +2 to +3
Copy link
Copy Markdown

@lucasmcdonald3 lucasmcdonald3 Apr 27, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
setuptools>=75.0
build>=1.0
setuptools>=75.0,<76
build>=1.0,<2

nit: Ideally we wouldn't automatically pull in a breaking change, this can bite us by making our release workflow fail without us realizing why. (That happened to Jose 1-2 weeks ago.) But not a big deal for this repo

twine==3.8.0
wheel==0.38.4
#This is required for twine < 4.0
Expand Down
4 changes: 2 additions & 2 deletions test/source-build-check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ echo "Using working directory ${WORKINGDIR}"
echo "Using dist directory ${DISTDIR}"

echo "Locating the source build and copying it into the working directory."
DISTFILE=$(ls ${DISTDIR}/dynamodb-encryption-sdk-*.tar.gz | tail -1)
DISTFILE=$(ls ${DISTDIR}/dynamodb?encryption?sdk-*.tar.gz | tail -1)
echo "Found source build at ${DISTFILE}"
cp ${DISTFILE} ${WORKINGDIR}

echo "Extracting the source build."
cd ${WORKINGDIR}
NEWDISTFILE=$(ls dynamodb-encryption-sdk-*.tar.gz | tail -1)
NEWDISTFILE=$(ls dynamodb?encryption?sdk-*.tar.gz | tail -1)
echo "Using distfile ${NEWDISTFILE}"
tar xzvf ${NEWDISTFILE}
rm ${NEWDISTFILE}
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ basepython = python3
skip_install = true
deps = -rdev_requirements/release-requirements.txt
commands =
python setup.py sdist bdist_wheel
python -m build

[testenv:release-base]
basepython = python3
Expand Down
Loading