fix(otel): End all recording spans on non-terminal invocations - #650
Open
ayushiahjolia wants to merge 1 commit into
Open
fix(otel): End all recording spans on non-terminal invocations#650ayushiahjolia wants to merge 1 commit into
ayushiahjolia wants to merge 1 commit into
Conversation
ayushiahjolia
had a problem deploying
to
ai-pr-review-runtime
August 24, 2026 20:29 — with
GitHub Actions
Error
ayushiahjolia
temporarily deployed
to
ai-pr-review-runtime
August 24, 2026 20:29 — with
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
ayushiahjolia
force-pushed
the
fix/otel-end-spans-non-terminal-v2
branch
from
August 26, 2026 18:27
7996423 to
805ee60
Compare
ayushiahjolia
had a problem deploying
to
ai-pr-review-runtime
August 26, 2026 18:29 — with
GitHub Actions
Failure
ayushiahjolia
temporarily deployed
to
ai-pr-review-runtime
August 26, 2026 18:29 — with
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
ayushiahjolia
force-pushed
the
fix/otel-end-spans-non-terminal-v2
branch
from
August 26, 2026 18:54
805ee60 to
d3d37ee
Compare
ayushiahjolia
had a problem deploying
to
ai-pr-review-runtime
August 26, 2026 19:21 — with
GitHub Actions
Error
ayushiahjolia
temporarily deployed
to
ai-pr-review-runtime
August 26, 2026 19:21 — with
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
ayushiahjolia
force-pushed
the
fix/otel-end-spans-non-terminal-v2
branch
from
August 26, 2026 22:19
d3d37ee to
285573e
Compare
ayushiahjolia
force-pushed
the
fix/otel-end-spans-non-terminal-v2
branch
2 times, most recently
from
August 26, 2026 23:40
0af9b13 to
af20a34
Compare
Contributor
Author
|
/ai review |
This comment has been minimized.
This comment has been minimized.
ayushiahjolia
force-pushed
the
fix/otel-end-spans-non-terminal-v2
branch
from
August 27, 2026 18:28
af20a34 to
6372919
Compare
Contributor
Author
|
/ai review |
ayushiahjolia
force-pushed
the
fix/otel-end-spans-non-terminal-v2
branch
from
August 27, 2026 18:41
6372919 to
1b92765
Compare
Contributor
Author
|
/ai review |
This comment has been minimized.
This comment has been minimized.
ayushiahjolia
marked this pull request as ready for review
August 27, 2026 19:13
ayushiahjolia
had a problem deploying
to
ai-pr-review-runtime
August 27, 2026 19:13 — with
GitHub Actions
Failure
Contributor
Codex AI reviewNo actionable findings. Residual risk: lifecycle tracking is hook-level; no runner-level test verifies that PENDING/RETRYING executions leave no recording spans open. Reviewed commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
#624
Description
Ensures no recording span is ever left un-ended on a non-terminal (PENDING/RETRYING) invocation, which previously abandoned open Workflow and operation spans on every suspend.
Demo/Screenshots
N/A
Checklist
Testing
Unit Tests
Have unit tests been written for these changes? Updated
Integration Tests
Have integration tests been written for these changes? N/A
Examples
Has a new example been added for the change? (if applicable) N/A