Skip to content

Added DRS example files - #10308

Closed
RyanFitzSimmonsAK wants to merge 19 commits into
aws:developfrom
RyanFitzSimmonsAK:develop-drs-examples
Closed

RyanFitzSimmonsAK wants to merge 19 commits into
aws:developfrom
RyanFitzSimmonsAK:develop-drs-examples

Conversation

@RyanFitzSimmonsAK

Copy link
Copy Markdown
Contributor

*Issue #, if available: Internal docs feedback ticket

*Description of changes: Added a directory for DRS and added the provided examples files. Manually checked that these examples render correctly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions github-actions Bot mentioned this pull request May 14, 2026
2 tasks
@codecov-commenter

codecov-commenter commented May 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.51%. Comparing base (c4681b5) to head (e02ad96).
⚠️ Report is 570 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (c4681b5) and HEAD (e02ad96). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (c4681b5) HEAD (e02ad96)
18 15
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #10308       +/-   ##
============================================
- Coverage    93.39%   44.51%   -48.88%     
============================================
  Files          210      301       +91     
  Lines        17052    36721    +19669     
============================================
+ Hits         15925    16347      +422     
- Misses        1127    20374    +19247     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ashovlin ashovlin added the documentation This is a problem with documentation. label May 18, 2026

@kdaily kdaily left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of new docs, nice!

Few things to check, see inline comments.

Also, check for the formatting of recovery instance IDs in these files (and maybe more?): disconnect-recovery-instance.rst, stop-failback.rst, get-failback-replication-configuration.rst, reverse-replication.rst, start-failback-launch.rst, terminate-recovery-instances.rst, and update-failback-replication-configuration.rst. Looks like recovery instance ID uses s-1234567890abcdef0. Do actual DRS recovery instance IDs use i- prefix (EC2 instance IDs)?

The describe-recovery-instances.rst output correctly shows "recoveryInstanceID": "i-1234567890abcdef0" and "ec2InstanceID": "i-1234567890abcdef0", but the commands using --recovery-instance-id pass in s-1234567890abcdef0.

Comment thread awscli/examples/drs/export-source-network-cfn-template.rst Outdated
Comment thread awscli/examples/drs/describe-launch-configuration-templates.rst Outdated
Comment thread awscli/examples/drs/start-failback-launch.rst Outdated
Comment thread awscli/examples/drs/terminate-recovery-instances.rst Outdated
Comment thread awscli/examples/drs/tag-resource.rst Outdated
Comment thread awscli/examples/drs/describe-source-networks.rst Outdated
Comment thread awscli/examples/drs/describe-jobs.rst Outdated
Comment thread awscli/examples/drs/describe-recovery-instances.rst Outdated
Co-authored-by: Kenneth Daily <kdaily@amazon.com>
@RyanFitzSimmonsAK
RyanFitzSimmonsAK requested a review from a team as a code owner June 12, 2026 22:38
Co-authored-by: Kenneth Daily <kdaily@amazon.com>
@kdaily kdaily added the pr:work-in-progress This PR is a draft and needs further work. label Jun 15, 2026
@kdaily

kdaily commented Jun 15, 2026

Copy link
Copy Markdown
Member

Also note the failing CI test, there seems to be a missing required parameter to one of the example commands:

https://github.com/aws/aws-cli/actions/runs/27447126863/job/81134513239?pr=10308#step:5:975

@RyanFitzSimmonsAK RyanFitzSimmonsAK closed this by deleting the head repository Oct 19, 2026
@RyanFitzSimmonsAK

Copy link
Copy Markdown
Contributor Author

Closing this in favor of #10778 which merges into the correct branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation This is a problem with documentation. pr:work-in-progress This PR is a draft and needs further work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants