Add configurable agent model selection#253
Draft
isadeks wants to merge 4 commits into
Draft
Conversation
added 2 commits
June 10, 2026 21:33
…lection # Conflicts: # lambda/agents/index.js
jeromevdl
reviewed
Jun 11, 2026
jeromevdl
reviewed
Jun 11, 2026
jeromevdl
reviewed
Jun 11, 2026
jeromevdl
reviewed
Jun 11, 2026
jeromevdl
reviewed
Jun 11, 2026
| return response(200, { available: [...cliSet] }); | ||
| return response(200, { | ||
| available: [...cliSet], | ||
| runtimeModelOverride: { kiro: true, claude: false, opencode: true }, |
Contributor
There was a problem hiding this comment.
maybe we should move this as a constant on top of the file and explain why claude is false as a comment...
Author
There was a problem hiding this comment.
Done. Moved this into a top-level RUNTIME_MODEL_OVERRIDE constant and added a comment explaining why Claude is false for this draft.
jeromevdl
reviewed
Jun 11, 2026
| expect(normalizeCliModels('{"opencode":"amazon-bedrock/model"}')).toEqual({ | ||
| valid: true, | ||
| issues: [], | ||
| value: { opencode: 'amazon-bedrock/model' }, |
Contributor
There was a problem hiding this comment.
maybe we should test this also in the code, that models for opencode start with "amazon-bedrock/"? just to make sure they don't simply use the bedrock model id as-is
Author
There was a problem hiding this comment.
Added validation and a test for this. OpenCode model overrides now must start with amazon-bedrock/ so users do not save the raw Bedrock model ID by mistake.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draft Status
This PR is intentionally still a draft. The implementation has unit/type/lint coverage and has been deployed to the dev stack for smoke checks, but it has not been fully end-to-end tested with a real agent run yet.
The remaining full smoke test requires Admin Agent Settings to have a valid Kiro API key or Bedrock bearer token, then starting a real agent run and verifying the model-selection log lines in CloudWatch.
Claude model override is intentionally not exposed yet. This draft enables runtime model selection for Kiro and OpenCode first because those drivers have clear, verifiable model configuration paths. Claude remains on its driver default until we validate a safe ACP/SDK override path; that can be handled later in this PR after Kiro/OpenCode are validated, or as a follow-up if it needs deeper driver work.
Verification
Smoke Test Notes
Closes #13