Skip to content

refactor : Deprecated the UsersAPIClient #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pmathew92 merged 1 commit into from
Mar 4, 2026
Merged

refactor : Deprecated the UsersAPIClient #930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions auth0/src/main/java/com/auth0/android/management/ManagementException.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ package com.auth0.android.management
import com.auth0.android.Auth0Exception
import com.auth0.android.NetworkErrorException


@Deprecated(
"""ManagementException is deprecated and will be removed in the next major version of the SDK. """,
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deprecation message string has a trailing space before the closing quotes, which will show up in the compiler warning text ("SDK. "). Remove the extra whitespace so the warning message is clean.

Suggested change
"""ManagementException is deprecated and will be removed in the next major version of the SDK. """,
"""ManagementException is deprecated and will be removed in the next major version of the SDK.""",

Copilot uses AI. Check for mistakes.
level = DeprecationLevel.WARNING
)
Comment on lines +7 to +10
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecating ManagementException will also effectively deprecate any public APIs that expose it (e.g., com.auth0.android.callback.ManagementCallback uses it in its signature). Consider deprecating those related types in the same PR or adjusting them to use a non-deprecated exception type to avoid surprising warnings for consumers.

Copilot uses AI. Check for mistakes.
Comment on lines +7 to +10
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description/title mention deprecating UsersAPIClient, but this change also deprecates ManagementException. Please update the PR description (or split the change) so release notes and reviewers don't miss this additional public API deprecation.

Copilot uses AI. Check for mistakes.
public class ManagementException @JvmOverloads constructor(
message: String,
exception: Auth0Exception? = null
Expand Down
5 changes: 5 additions & 0 deletions auth0/src/main/java/com/auth0/android/management/UsersAPIClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ import java.io.Reader
*
* @see [Auth API docs](https://auth0.com/docs/api/management/v2)
*/

@Deprecated(
"""UsersAPIClient is deprecated and will be removed in the next major version of the SDK.""",
level = DeprecationLevel.WARNING
)
public class UsersAPIClient @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE) internal constructor(
private val auth0: Auth0,
private val factory: RequestFactory<ManagementException>,
Expand Down