Skip to content

test: add optimize --output=overwrite coverage - #2259

Open
Aastha204 wants to merge 1 commit into
asyncapi:masterfrom
Aastha204:test/optimize-overwrite-coverage
Open

test: add optimize --output=overwrite coverage#2259
Aastha204 wants to merge 1 commit into
asyncapi:masterfrom
Aastha204:test/optimize-overwrite-coverage

Conversation

@Aastha204

Copy link
Copy Markdown

Description

Adds missing integration test coverage for the optimize command's --output=overwrite path.

Previously, terminal and new-file outputs were covered, but overwrite was not. That meant regressions in in-place file updates could slip through unnoticed.

Changes

  • Add YAML overwrite test: copy fixture to a temp file, run optimize --no-tty -o overwrite, assert success message and that content changed
  • Add JSON overwrite test with the same flow
  • Use os.tmpdir() copies so fixture files are never mutated
  • Clean up temp files in afterEach

Related issue(s)

Fixes #1933

Test plan

  • npm run test:one -- test/integration/optimize.test.ts → 14 passing

@changeset-bot

changeset-bot Bot commented Jul 25, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f5f459b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Triage

Development

Successfully merging this pull request may close these issues.

[BUG] optimize command: missing test coverage for --output=overwrite

1 participant