fix: Split unmanaged & managed resources and orphan detection#757
Merged
zachdaniel merged 1 commit intoMay 21, 2026
Merged
Conversation
zachdaniel
approved these changes
May 20, 2026
Contributor
|
Let's address the reuse compliance issues and any other failing checks. The audit one can be ignored. |
Contributor
Author
|
The failing checks are because of an already failing branch that I started work off of, which was in master. |
Contributor
|
I'll sort it out in main 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
migrate? false dropped unmanaged tables too eagerly.
Fixed it to split unmanaged and managed resources,and pass unmanaged resources to orphan detection.
So final current_table_keys becomes the proper managed U unmanaged.
Fixes #756
Contributor checklist
Leave anything that you believe does not apply unchecked.