Enable residual calculation during irradiation and evaluation#48
Enable residual calculation during irradiation and evaluation#48LukeSeifert wants to merge 104 commits intoarfc:mainfrom
Conversation
ZoeRichter
left a comment
ZoeRichter
left a comment
There was a problem hiding this comment.
Looks good overall - I have some small changes and questions. A general comment is that while the whitespace looks right at a glance, you have some lines that are beyond the PEP8 character limit that need to be split over multiple lines. I
| "hls": [55.89897, 22.72614, 6.24457, 2.30281, 0.60802, 0.23028] | ||
| }, | ||
| "saturation (12 Group)": { | ||
| "description": "Calculated using ENDFB71 data, post-irrad, (0.00001,0) 0.00001 second irradiation, 100 decay times, 600 decay seconds", |
There was a problem hiding this comment.
do users (currently, you) enter this data by hand? If it isn't automated, I think you should consider scripting this bit somehow.
There was a problem hiding this comment.
Good suggestion! Created Issue #56 for this. There should be an option for manual data entry, but generally users should be able to just pass in the path to where their mosden output files live.
| @@ -24,7 +24,8 @@ | |||
| "processed_data_dir": f"{current_dir}/", | |||
There was a problem hiding this comment.
Are these defaults you could incorporate into your classes? Maybe add a 'simulation' class or something similar?
There was a problem hiding this comment.
I could, but I have found it useful to have this separate defaults file. When I want to look through my default arguments, it is very convenient to have a single script that contains all those arguments.
| The processed data for the fissile nuclide. | ||
|
|
||
| """ | ||
| data_path = os.path.join(self.processed_data_dir, f'{data_type}.csv') |
There was a problem hiding this comment.
If you're already using os.path, another tip is that os.path has an "expand" function that converts paths using the ~/ shorthand into the full path for you.
There was a problem hiding this comment.
For this use case it might not be necessary (since processed_data_dir is defined relative to the input file path), but I'll have to think about if that might be useful to have elsewhere
|
Thanks for the feedback @ZoeRichter! Let me know if there are any other changes you think should be made in this PR, otherwise feel free to merge if everything looks good. |
2 participants
Summary of changes
This PR enables users to include calculation of the residual during irradiation, which differs from existing methodologies which only allow for calculation of residuals post-irradiation.
This PR also includes a point reactor kinetics solver in the
phd_resultsexample, such that comparisons can be made between results calculated using different methodologies to evaluate their impact on simplified reactor transients.Also in this PR is a small change to the code such that a minimum timestep can be set for OpenMC. This allows the user to use a smaller timestep while maintaining the same in-core and ex-core residence times.
Finally, this PR also includes the
debug DNPfunctionality, such that users may manually define a DNP for testing purposes.Many of the line changes are due to changes in the integration test files. These changed because I have added the count rate at time 0 for easier debugging and to mitigate bugs in time offsets.
The main components I would like reviewed closely are the actual MoSDeN code changes (changes to the examples and tests are less critical; most of the test changes just cover testing the new functionality and adjustments based on restructured output files)
Types of changes
Associated Issues and PRs
PRs:
#46 must be merged before this PR
Issues:
Associated Developers
Checklist for Reviewers
Reviewers should use this link to get to the
Review Checklist before they begin their review.