Skip to content

Remove deprecated curl_close calls#67

Closed
ChiragAgg5k wants to merge 1 commit intomainfrom
codex/remove-curl-close-php85
Closed

Remove deprecated curl_close calls#67
ChiragAgg5k wants to merge 1 commit intomainfrom
codex/remove-curl-close-php85

Conversation

@ChiragAgg5k
Copy link
Copy Markdown
Member

What does this PR do?

Removes calls to curl_close(). Since PHP 8.0, cURL handles are CurlHandle objects and curl_close() no longer has an effect; handles are released by object lifetime instead. Removing these calls avoids noisy PHP 8.5 deprecation warnings without changing behavior for supported PHP versions.

Test Plan

  • Ran php -l on changed PHP files where applicable.
  • Confirmed no curl_close(...) calls remain in this repository.

Related PRs and Issues

N/A

Have you read the Contributing Guidelines on issues?

Yes.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 29, 2026

Greptile Summary

Removes the curl_close($ch) call from Client::call(). Since PHP 8.0, CurlHandle objects are released when they go out of scope, making curl_close() a no-op; PHP 8.5 promotes this to a deprecation warning. The change is correct and has no behavioral impact on supported PHP versions.

Confidence Score: 5/5

Safe to merge — single-line removal with no behavioral change on any supported PHP version.

The change removes a call that has been a documented no-op since PHP 8.0. No logic is altered, no resource management is affected, and the handle is correctly released by object lifetime. No issues found.

No files require special attention.

Important Files Changed

Filename Overview
src/Appwrite/Client.php Removes the now-deprecated curl_close($ch) call; handle release is handled automatically by PHP's object lifetime since PHP 8.0.

Reviews (1): Last reviewed commit: "Remove deprecated curl_close calls" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant