Skip to content

Fix formula component order to satisfy brew style#2

Merged
ChiragAgg5k merged 1 commit intomainfrom
fix/formula-components-order
Apr 17, 2026
Merged

Fix formula component order to satisfy brew style#2
ChiragAgg5k merged 1 commit intomainfrom
fix/formula-components-order

Conversation

@ChiragAgg5k
Copy link
Copy Markdown
Member

Summary

  • Swap version and license so version comes first (Homebrew's canonical component order).
  • Move the head block above on_macos/on_linux for the same reason.
  • This unblocks the test-bot --only-tap-syntax job on every CI run — it has been failing since bootstrap with FormulaAudit/ComponentsOrder errors.

Why this surfaced now

Dependabot PR #1 (bumping actions/cache v4 → v5) exposed the failure — but the style violations were always there and would have blocked any release PR opened by the CLI publish workflow. Fixing this here means subsequent PRs (including the dependabot one) will go green.

Verification (local)

Against this branch's formula, run from the tapped directory:

  • brew style appwrite/appwrite/appwrite1 file inspected, no offenses detected
  • brew audit --strict --tap=appwrite/appwrite appwrite → clean
  • brew readall --aliases --os=all --arch=all appwrite/appwrite → clean

Test plan

  • CI (test-bot --only-tap-syntax) passes on both ubuntu-latest and macos-latest
  • After merging, rebase/retry dependabot PR Bump actions/cache from 4 to 5 #1 and confirm it goes green

`brew style` enforces Homebrew's canonical component order:
- `version` before `license`
- `head` before `on_macos`/`on_linux`

The bootstrap formula had both swapped, so every `test-bot --only-tap-syntax` run fails the style check — which is what surfaced on dependabot PR #1 (bumping `actions/cache`).

Verified locally: `brew style`, `brew audit --strict`, and `brew readall --aliases --os=all --arch=all` all pass with this ordering.
@ChiragAgg5k ChiragAgg5k merged commit 89b997d into main Apr 17, 2026
2 checks passed
@ChiragAgg5k ChiragAgg5k deleted the fix/formula-components-order branch April 17, 2026 12:10
ChiragAgg5k added a commit that referenced this pull request Apr 17, 2026
Supersedes dependabot PR #1, which was blocked on pre-existing `brew style` component-order errors now fixed in #2. GitHub-hosted `ubuntu-latest`/`macos-latest` runners already satisfy `actions/cache@v5`'s Node 24 + runner ≥2.327.1 requirements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant