feat: add bigint column type support and update dependencies#2950
feat: add bigint column type support and update dependencies#2950ArnabChatterjee20k wants to merge 18 commits intomainfrom
Conversation
Greptile SummaryThis PR introduces
Confidence Score: 5/5Safe to merge; all changed paths are well-structured and previously flagged precision trade-offs are acknowledged by the team The bigint serialisation pipeline (normalizeBigInt to buildPayload to String cast) is internally consistent and handles null/undefined/array edge cases correctly. The SDK rename follow-ons are mechanical and verified against the updated package. No new unaddressed defects were found beyond the two style nits above. bigint.svelte deserves a second look to confirm the InputNumber precision trade-off is acceptable for the product's expected bigint range Important Files Changed
Reviews (11): Last reviewed commit: "updated proxy status" | Re-trigger Greptile |
- Updated bigint column type handling in the database table columns. - Refactored input components to use InputText for bigint values with validation. - Improved parsing and error handling for bigint inputs in string representation. - Adjusted type definitions to include bigint in various contexts.
- Added bigint type to the Columns type definition. - Updated bigint input handling in the bigint.svelte component, replacing InputText with InputNumber for better user experience. - Enhanced data binding and validation for bigint values, including min, max, and default settings. - Adjusted column value handling in various components to accommodate bigint type.
|
Tip: Greploop — Automatically fix all review issues by running Use the Greptile plugin for Claude Code to query reviews, search comments, and manage custom context directly from your terminal. |
| tableId: page.params.table, | ||
| rowId: row.$id, | ||
| data: row | ||
| data: buildPayload(columns, row as Record<string, unknown>) |
There was a problem hiding this comment.
Why unknown here instead of a typed row?
Do we not know the shape,
Can't we define a type?
…nt.svelte component
…tion in function and site creation
fix: update proxy rule status handling and improve variable ID genera…
What does this PR do?
(Provide a description of what this PR does.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)