Surface a clear error when system start cannot write app-root - #2059
Open
rogerneal wants to merge 1 commit into
Open
Surface a clear error when system start cannot write app-root#2059rogerneal wants to merge 1 commit into
rogerneal wants to merge 1 commit into
Conversation
Replace opaque Cocoa failures with ContainerizationError messages when creating the apiserver data directory or writing its plist under a non-writable --app-root, and add regression tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--app-rootfails with a clearContainerizationErrorinstead of an opaque Cocoa / fatal path.try!crash was already fixed in fix: propagate error from createDirectory in system start #1785; this finishes the user-facing side of [Bug]: container system start crashes with fatal error when app-root directory is not writable #1802 with actionable messaging and regression coverage.Closes #1802
Test plan
Tested
swift test --filter SystemStartAppRootTests(2/2 passed)app-root must be writable1(not133)Fatal error/try!cannot create application data directory ... app-root must be writableNot tested