Skip to content

test: Stabilize crawler tests that need two requests in parallel - #2454

Open
Mantisus wants to merge 1 commit into
apify:v2from
Mantisus:flaky-overload-tests
Open

Mantisus wants to merge 1 commit into
apify:v2from
Mantisus:flaky-overload-tests

Conversation

@Mantisus

Copy link
Copy Markdown
Collaborator

Description

  • Three BasicCrawler tests wait for two request handlers to run at the same time. On an overloaded machine, the concurrency system starts only min_concurrency tasks, 1 by default, so the second handler never started and the tests failed or hung on busy CI runners. The tests now set min_concurrency=2.

Testing

  • With every load check reporting an overload, the three tests pass, where they failed or hung before. Under the same forced overload, no other unit test depends on requests running in parallel.

✍️ Drafted by Claude Code

@github-actions github-actions Bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Nov 15, 2026
@Mantisus Mantisus self-assigned this Nov 15, 2026
@Mantisus
Mantisus requested a review from vdusek November 15, 2026 21:28

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant