Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2213 +/- ##
=======================================
Coverage 93.74% 93.74%
=======================================
Files 181 181
Lines 12865 12877 +12
=======================================
+ Hits 12060 12072 +12
Misses 805 805
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
8dcdd20 to
18a51db
Compare
|
If I'm not mistaken, |
| "opentelemetry-distro[otlp]>=0.54", | ||
| "opentelemetry-instrumentation>=0.54", | ||
| "opentelemetry-instrumentation-httpx>=0.54", | ||
| "opentelemetry-distro[otlp]>=0.54b0", |
There was a problem hiding this comment.
I think you should bump all the instrumentation-related 0.54b0 to 0.65b0.
For unrelated Python packages, this would not be needed, but those instrumentation packages are always bumped all together.
So, for example, this gives the illusion of flexibility
opentelemetry-semantic-conventions>=0.54b0
opentelemetry-instrumentation-httpx>=0.65b0
, but in reality it resolves as
opentelemetry-semantic-conventions>=0.65b0
opentelemetry-instrumentation-httpx>=0.65b0
cc @Pijukatel |
HttpxHttpClientruns onhttpx2, andopentelemetry-instrumentation-httpxonly gainedHTTPX2ClientInstrumentorin 0.65b0, so requests through it produced no spans. Every OpenTelemetry floor in theotelextra now sits on that release line.opentelemetry-api>=1.34.1>=1.44.0opentelemetry-distro[otlp]>=0.54>=0.65b0opentelemetry-instrumentation>=0.54>=0.65b0opentelemetry-instrumentation-httpx>=0.54>=0.65b0opentelemetry-sdk>=1.34.1>=1.44.0opentelemetry-semantic-conventions>=0.54>=0.65b0Verified against the wheels: 0.64b0 registers a single
httpxentry point, while 0.65b0 adds the class and anhttpx2entry point. With an in-memory exporter,HTTPX2ClientInstrumentoremits a span for anHttpxHttpClientrequest;HTTPXClientInstrumentoremits none.The whole group moves together because these packages release in lockstep and pin each other with
==.opentelemetry-instrumentation-httpx==0.65b0requiresopentelemetry-instrumentation==0.65b0andopentelemetry-semantic-conventions==0.65b0, and the latter requiresopentelemetry-api==1.44.0;opentelemetry-sdkpinsapito its own version, so it lands on 1.44.0 as well.uv pip compile --resolution lowest-directagainst the old specifiers resolves to exactly the "after" column, so the previous floors only looked permissive.Every release of the 0.x packages is a beta, so the floors name the prerelease explicitly.
>=0.65matches no published version at all, since PEP 440 orders0.65b0 < 0.65.uv.lockhad already resolved 0.65b0 and 1.44.0, so only itsrequires-distspecifiers moved.The web form example corrections that used to ride along here moved to #2237.
✍️ Drafted by Claude Code