refactor: Fix redundant func import in request queue client#1788
Open
LincolnBurrows2017 wants to merge 2 commits intoapify:masterfrom
Open
refactor: Fix redundant func import in request queue client#1788LincolnBurrows2017 wants to merge 2 commits intoapify:masterfrom
LincolnBurrows2017 wants to merge 2 commits intoapify:masterfrom
Conversation
added 2 commits
March 11, 2026 22:45
- Remove duplicate 'from sqlalchemy import func as sql_func' import - Use consistent 'func' naming throughout the file
vdusek
changed the title
Mantisus
approved these changes
Mar 12, 2026
vdusek
approved these changes
Mar 12, 2026
Collaborator
vdusek
left a comment
vdusek
left a comment
There was a problem hiding this comment.
Hi @LincolnBurrows2017, thanks for your contribution! I'll just make the PR refactor type, as it is not a bug fix.
Collaborator
|
@LincolnBurrows2017 please fix linting issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a redundant import in
src/crawlee/storage_clients/_sql/_request_queue_client.py:from sqlalchemy import func as sql_funcimportfuncnaming throughout the fileThis improves code clarity by eliminating the confusing duplicate import for the same module.