Conversation
vdusek
added
adhoc
vdusek
added
adhoc
github-actions
bot
added
the
tested
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #831 +/- ##
==========================================
- Coverage 86.47% 86.44% -0.04%
==========================================
Files 48 48
Lines 2899 2899
==========================================
- Hits 2507 2506 -1
- Misses 392 393 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ration tests In shared request queue mode, the Apify API has an eventual consistency propagation delay before newly added or reclaimed requests become visible in fetch_next_request(). Many integration tests were missing the call_with_exp_backoff() retry pattern, causing sporadic failures. Also added rq_access_mode parameter to call_with_exp_backoff() so callers can pass it directly instead of wrapping every call in an if/else block. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
vdusek
force-pushed
the
fix/flaky-integration-tests-shared-rq
branch
from
2b86354 to
cba00a1
Compare
vdusek
changed the title
vdusek
force-pushed
the
fix/flaky-integration-tests-shared-rq
branch
from
a62c882 to
ac81511
Compare
vdusek
force-pushed
the
fix/flaky-integration-tests-shared-rq
branch
from
f0caed1 to
f20c29f
Compare
Pijukatel
approved these changes
Mar 13, 2026
Using call_with_exp_backoff in `while not is_empty/is_finished` loop conditions caused infinite loops in shared mode — the backoff retried 3 times (7s) per iteration even when the queue legitimately had items, leading to 1800s+ timeouts on large batches. Replaced with walrus operator `while request := await call_with_exp_backoff(fetch_next_request)` pattern in test_large_batch_operations, test_persistence_across_operations, and test_concurrent_processing_simulation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
call_with_exp_backoff(rq.fetch_next_request)for shared mode in all integration tests that fetch requests right after adding/reclaiming themrequest: pytest.FixtureRequestparameter to tests that were missing it for shared mode detectionTest plan
singleandsharedparameterizations)test_rq_long_url[shared]failures (and similar tests)🤖 Generated with Claude Code