Fix server entry cleanup after request tunnel setup#13295
Open
bneradt wants to merge 1 commit into
Open
Conversation
A crash was observed while an HTTP/2 stream finished sending an
origin request header and started the client request body tunnel:
#0 HttpSM::state_send_server_request_header(...)
at src/proxy/http/HttpSM.cc:2176
#1 HttpSM::main_handler(...)
at src/proxy/http/HttpSM.cc:2731
#5 Http2Stream::signal_write_event(...)
at src/proxy/http2/Http2Stream.cc:954
The core had server_entry == nullptr at the vc_type check after the
request-body tunnel setup. The tunnel can synchronously abort the chain
and clean up the server VC before returning.
This checks whether the server entry still exists after setting up the
request body tunnel or transform tunnel. When setup already cleaned it
up, the state handler stops before installing a response-read handler
on a null entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A crash was observed while an HTTP/2 stream finished sending an
origin request header and started the client request body tunnel:
The core had server_entry == nullptr at the vc_type check after the
request-body tunnel setup. The tunnel can synchronously abort the chain
and clean up the server VC before returning.
This checks whether the server entry still exists after setting up the
request body tunnel or transform tunnel. When setup already cleaned it
up, the state handler stops before installing a response-read handler
on a null entry.