Repository navigation
Conversation
When an EL function whose method is varargs was called with exactly one argument for the varargs parameter, AstFunction evaluated that argument twice: once to check whether it is already an array and once more for the value. An argument with side effects ran twice, the function received the result of the second evaluation, and an expensive argument cost double. Evaluate the argument once and use the value both for the array check and as the single varargs element. Calls with two or more varargs values and the single array argument case are unchanged. Adds a test that counts the evaluations of a method call used as the single varargs argument. The test reports two evaluations against the previous implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an EL function whose method is varargs was called with exactly one argument for the varargs parameter, AstFunction evaluated that argument twice: once to check whether it is already an array and once more for the value. An argument with side effects ran twice, the function received the result of the second evaluation, and an expensive argument cost double.
Evaluate the argument once and use the value both for the array check and as the single varargs element. Calls with two or more varargs values and the single array argument case are unchanged.
Adds a test that counts the evaluations of a method call used as the single varargs argument. The test reports two evaluations against the previous implementation.