TINKERPOP-3232 Coerce set into list when it contains non-hashable elements#3359
Open
TINKERPOP-3232 Coerce set into list when it contains non-hashable elements#3359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-3232
Originally thought of using HashableDict, but ended up with deserializing into list instead due to potential hash collision and silent mutations of nested objects. Given gremlin-go also uses lists to back its custom set type, this wouldn't be an exclusion. Also this best preserves the inner data and type, which is usually what users operate on.
However, I did keep a commit with the HashableDict.of() in case we favor that solution instead. Note there could be an improvement to this, where we use
frozensetforsetinstead oftuplein the HashableDict implementation.(I will add CHANGELOG entry after the decision is made on the approach.)
VOTE +1