THRIFT-4987: Fix TBinaryProtocol support in XHRConnection#3341
Closed
CJCombrink wants to merge 4 commits intoapache:masterfrom
Closed
THRIFT-4987: Fix TBinaryProtocol support in XHRConnection#3341CJCombrink wants to merge 4 commits intoapache:masterfrom
CJCombrink wants to merge 4 commits intoapache:masterfrom
Conversation
Contributor
Author
|
This PR is based of #3331 and will be opened once it is merged. |
mergeable
bot
added
nodejs
typescript
compiler
github_actions
CJCombrink
force-pushed
the
fix_binary_xhr_connection
branch
from
63b2fbd to
cdff706
Compare
- Picking up THRIFT-4987 based on feedback and other PRs and local thrift patches for npm package - Changes most probably originated from apache#2645 and apache#2157 that went stale and PRs were closed
- This assumes that any other protocol except TJSONProtocol will have this bug - This also fixes the issue for TCompactProtocol - Unit test incoming that is kept separate from the fix commit for reasons
- This is a regression and demonstration test showing that the fix applied does work for TBinaryProtocol, TCompactProtocol and TJSONProtocol - This test is Claude AI generated, read the disclaimer in the file
CJCombrink
force-pushed
the
fix_binary_xhr_connection
branch
from
cdff706 to
29c3468
Compare
CJCombrink
commented
Mar 17, 2026
| * "TProtocolException: Bad version in readMessageBegin when using XHR | ||
| * client with binary protocol against a C++ server" | ||
| * | ||
| * Disclaimer: This file, except for this disclaimer, was written entirely by |
Contributor
Author
There was a problem hiding this comment.
Please note this disclaimer in this file
- Not sure how I lost this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix TBinaryProtocol in XHRConnection
This picks up two previous PRs and local node package patches with the hope that it can be fixed in the next version of Thrift.
Compared to the previous two PRs the changes here attempts to preserve the current behavior for other protocols.
[skip ci]anywhere in the commit message to free up build resources.