Skip to content

[THRIFT-5757] PHP cross test#2957

Open
sveneld wants to merge 2 commits intoapache:masterfrom
sveneld:php_cross_test
Open

[THRIFT-5757] PHP cross test#2957
sveneld wants to merge 2 commits intoapache:masterfrom
sveneld:php_cross_test

Conversation

@sveneld
Copy link
Copy Markdown
Contributor

@sveneld sveneld commented Apr 4, 2024

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@sveneld sveneld marked this pull request as draft April 4, 2024 18:01
@Jens-G Jens-G added the php label Apr 4, 2024
@Jens-G Jens-G added the rebase needed rebase needed label May 19, 2025
@Jens-G
Copy link
Copy Markdown
Member

Jens-G commented Nov 20, 2025

What's the status with this draft?

@sveneld
Copy link
Copy Markdown
Contributor Author

sveneld commented Nov 21, 2025

I haven't time to finish it. I will try to pay attention to this pull request on next week. When you plan to make a new release?

@Jens-G
Copy link
Copy Markdown
Member

Jens-G commented Nov 21, 2025

When you plan to make a new release?

There is no fixed plan, about twice a year. There are some ideas about 0.23.0 but there is still some work in progress, so most likely not before December. OTOH how important is that at all? I mean, we talk about the cross test. Super awesome w/regard to the Github actions but not really mission critical IMHO.

So either way I leave that PR open for now.

@sveneld
Copy link
Copy Markdown
Contributor Author

sveneld commented Nov 21, 2025

It's important for further update of supported php version. I want to implement new features of language and remove deprecations. So i will be better to test code. Let it opened, I will to try to implement this test in this month. Thank you

@mergeable mergeable bot added python compiler testsuite build and general CI cmake, automake and build system changes github_actions Pull requests that update GitHub Actions code labels Mar 26, 2026
@sveneld sveneld marked this pull request as ready for review March 26, 2026 21:00
@sveneld
Copy link
Copy Markdown
Contributor Author

sveneld commented Mar 26, 2026

@Jens-G finally updated

Copy link
Copy Markdown
Contributor Author

@sveneld sveneld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments in code

@sveneld
Copy link
Copy Markdown
Contributor Author

sveneld commented Mar 27, 2026

@pkvach take a look.

@pkvach
Copy link
Copy Markdown
Contributor

pkvach commented Mar 27, 2026

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build and general CI cmake, automake and build system changes compiler github_actions Pull requests that update GitHub Actions code php python rebase needed rebase needed testsuite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants