Set the minimum macOS version to 13#239
Merged
BewareMyPower merged 3 commits intoapache:mainfrom Jan 24, 2025
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the build workflow for macOS wheels run on macos-14 runner so that the wheel's target macOS version is 14. This is because the
-mmacosx-version-minoption is not specified when building Python from source.You can find the following log in https://github.com/apache/pulsar-client-python/actions/runs/12878584451/job/35904753892
We need to add
MACOSX_DEPLOYMENT_TARGETas the environment variable, see https://github.com/python/cpython/blob/ec91e1c2762412f1408b0dfb5d281873b852affe/configure#L10759Here we set it with 13 because 13 is the current minimum maintained version, see https://en.wikipedia.org/wiki/MacOS_version_history