[fix][release] Skip docker build record artifacts when staging release#473
Merged
shibd merged 1 commit intoapache:masterfrom Mar 31, 2026
Merged
Conversation
Recent release workflow runs include auxiliary *.dockerbuild artifacts uploaded by docker/build-push-action. Our staging script downloaded every artifact from the workflow run and tried to unzip them as release packages, which caused stage-release.sh to fail with BadZipFile before the actual napi tarballs were processed.\n\nSkip *.dockerbuild artifacts in download-release-artifacts.py and keep the error message explicit for unexpected non-zip artifacts so release managers can stage 1.17.x and master builds again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Recent release workflow runs started to include auxiliary *.dockerbuild artifacts uploaded by docker/build-push-action.
build-support/download-release-artifacts.py currently downloads every artifact from a workflow run and unpacks each one as a release package. During release staging, build-support/stage-release.sh now fails with zipfile.BadZipFile as soon as it hits one of these auxiliary artifacts, before the actual N-API tarballs are processed.
This showed up while staging release artifacts from run 23788749811 for v1.17.0-rc.1.
Change
Verification