Fix delta forward index chunk caching - #19282
Open
xiangfu0 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19282 +/- ##
============================================
+ Coverage 67.09% 67.12% +0.03%
Complexity 1424 1424
============================================
Files 3459 3459
Lines 219789 219784 -5
Branches 35007 35006 -1
============================================
+ Hits 147457 147520 +63
+ Misses 60543 60483 -60
+ Partials 11789 11781 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes decoded chunk caching for DELTA codecs in raw forward-index readers.
Changes:
- Decodes chunks into the context-owned buffer.
- Invalidates cache state before decompression.
- Adds INT/LONG DELTA regression tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
BaseChunkForwardIndexReader.java |
Corrects buffer ownership and cache invalidation. |
FixedByteChunkSVForwardIndexTest.java |
Tests DELTA chunk transitions and revisits. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
xiangfu0
force-pushed
the
xiangfu0/codex/codec-delta-chunk-cache-fix
branch
from
August 18, 2026 02:46
19912b4 to
c78ad6b
Compare
xiangfu0
force-pushed
the
xiangfu0/codex/codec-delta-chunk-cache-fix
branch
from
August 18, 2026 07:18
c78ad6b to
a5d3700
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #18229 as an independent correctness prerequisite.
BaseChunkForwardIndexReader previously allocated a separate decoded buffer for DELTA and DELTADELTA without storing it in ChunkReaderContext. The first read returned correct data, but later reads in the same chunk reused the untouched context buffer. The extra direct allocation also escaped the context lifecycle.
This change decodes every compression type into the context-owned full-chunk buffer and invalidates the cached chunk id before decoding so failures cannot leave a false cache hit.
Tests:
This PR does not add codec-pipeline behavior and can merge independently of the codec stack.