Improve integration CI diagnostics for surefire fork startup failures#17843
Merged
xiangfu0 merged 1 commit intoapache:masterfrom Mar 15, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions integration test runner script to improve diagnostics for Maven Surefire fork startup failures and reduce fork JVM heap size for integration test set 2 to lower CI memory pressure.
Changes:
- Add a helper to print Surefire dump artifacts from
target/surefire-reportson test failures. - Update integration test execution to print Surefire dump files when
mvn testfails. - For
RUN_TEST_SET=2, override MavenargLineto use a smaller heap (-Xms1g -Xmx2g) while retaining the log4j2 config setting.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17843 +/- ##
============================================
+ Coverage 55.58% 63.30% +7.72%
- Complexity 727 1466 +739
============================================
Files 2497 3190 +693
Lines 141225 192002 +50777
Branches 22529 29412 +6883
============================================
+ Hits 78499 121554 +43055
- Misses 56072 60918 +4846
- Partials 6654 9530 +2876
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shauryachats
approved these changes
Mar 14, 2026
xiangfu0
added a commit
to xiangfu0/pinot
that referenced
this pull request
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This updates the integration test runner script used in GitHub Actions to make surefire fork startup failures easier to diagnose and reduce fork startup memory pressure for set 2.
Changes
print_surefire_dumps()in.github/workflows/scripts/pr-tests/.pinot_tests_integration.shtarget/surefire-reports(*.dump,*.dumpstream,*jvmRun*)RUN_TEST_SET=2, pass-DargLine="-Xms1g -Xmx2g -Dlog4j2.configurationFile=log4j2.xml"to lower fork JVM heap from default 4g/4gWhy
We saw CI fail with:
ExecutionException Error occurred in starting forkSurefireBooterForkExceptionThe dump files are the primary source of root-cause details for this class of error. Lowering surefire fork heap for set 2 should also reduce startup failures due to memory pressure on GitHub runners.
Validation
bash -n .github/workflows/scripts/pr-tests/.pinot_tests_integration.sh