Skip to content

WIP: avoid initializing classes via forName #3353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pjfanning wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: avoid initializing classes via forName #3353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion actor-typed/src/main/scala/org/apache/pekko/actor/typed/internal/LoggerClass.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ private[pekko] object LoggerClass {
lambdaNameIdx = nextName.indexOf("$$Lambda")
if nextName.startsWith(cls.getName()) && lambdaNameIdx > 0
lambdaClsOwner = nextName.substring(0, lambdaNameIdx)
} yield Class.forName(lambdaClsOwner)
} yield Class.forName(lambdaClsOwner, false, this.getClass.getClassLoader)
// TODO: can potentially guard for ClassNotFoundException, but seems unlikely
lambdaClsOwner.getOrElse(cls)
case _ =>
Expand Down
2 changes: 1 addition & 1 deletion persistence-tck/src/main/scala/org/apache/pekko/persistence/CapabilityFlags.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ sealed abstract class CapabilityFlag {
private val capturedStack = new Throwable().getStackTrace
.filter(_.getMethodName.startsWith("supports"))
.find { el =>
val clazz = Class.forName(el.getClassName)
val clazz = Class.forName(el.getClassName, false, this.getClass.getClassLoader)
clazz.getDeclaredMethod(el.getMethodName).getReturnType == classOf[CapabilityFlag]
}
.map { _.getMethodName }
Expand Down