refactor PDType1FontEmbedder constructor - #510
Closed
valerybokov wants to merge 1 commit into
Closed
Conversation
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Aug 31, 2026
…#510 git-svn-id: https://svn.apache.org/repos/asf/pdfbox/branches/3.0@1937670 13f79535-47bb-0310-9956-ffa450edef68
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Aug 31, 2026
…#510 git-svn-id: https://svn.apache.org/repos/asf/pdfbox/branches/2.0@1937669 13f79535-47bb-0310-9956-ffa450edef68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An instance of PfbParser will be created within the Type1Font.createWithPFB method. Therefore, in the current code, we have two instances of this type. Additionally, we can avoid usage of the PfbStream.readAllBytes method.