Skip to content

delete always the same offset argument in RC4Cipher.write method #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
valerybokov wants to merge 1 commit into from
Closed

delete always the same offset argument in RC4Cipher.write method #504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/RC4Cipher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ private byte encrypt(byte aByte)
*/
void write(byte[] data, OutputStream output) throws IOException
{
write(data, 0, data.length, output, new byte[data.length]);
write(data, data.length, output, new byte[data.length]);
}

/**
Expand All @@ -131,24 +131,23 @@ void write(InputStream data, OutputStream output) throws IOException
int amountRead;
while( (amountRead = data.read( buffer )) != -1 )
{
write(buffer, 0, amountRead, output, buffer);
write(buffer, amountRead, output, buffer);
}
}

/**
* This will encrypt and write the data.
*
* @param data The data to encrypt, may be overwritten.
* @param offset The offset into the array to start reading data from.
* @param len The number of bytes to attempt to read.
* @param output The stream to write to.
* @param buffer The buffer to use, it can be altered and be identical to the data to encrypt.
*
* @throws IOException If there is an error writing to the output stream.
*/
private void write(byte[] data, int offset, int len, OutputStream output, byte[] buffer) throws IOException
private void write(byte[] data, int len, OutputStream output, byte[] buffer) throws IOException
{
for (int i = 0, j = offset; i < len; ++i, ++j)
for (int i = 0, j = 0; i < len; ++i, ++j)
{
buffer[i] = encrypt(data[j]);
}
Expand Down