Skip to content

Fix banned imports in TestParquetFileReaderBufferLeak (since GH-3487) - #3774

Merged
Fokko merged 1 commit into
apache:masterfrom
abstractdog:banned-imports
Sep 4, 2026
Merged

Fix banned imports in TestParquetFileReaderBufferLeak (since GH-3487)#3774
Fokko merged 1 commit into
apache:masterfrom
abstractdog:banned-imports

Conversation

@abstractdog

@abstractdog abstractdog commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Rationale for this change

Eariler commit makes precommit fail as: https://github.com/apache/parquet-java/actions/runs/33898249347/job/101105940903?pr=3773

[ERROR] Reason: Use JUnit 5 (org.junit.jupiter.*) and AssertJ instead of JUnit 4
[ERROR] 	in file:///home/runner/work/parquet-java/parquet-java/parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestParquetFileReaderBufferLeak.java
[ERROR] 		static org.junit.Assert.assertEquals  	(Line: 23, Matched by: org.junit.**)
[ERROR] 		static org.junit.Assert.assertNotNull 	(Line: 24, Matched by: org.junit.**)
[ERROR] 		static org.junit.Assert.assertNull    	(Line: 25, Matched by: org.junit.**)
[ERROR] 		static org.junit.Assert.assertTrue    	(Line: 26, Matched by: org.junit.**)
[ERROR] 		org.junit.Rule                        	(Line: 47, Matched by: org.junit.**)
[ERROR] 		org.junit.Test                        	(Line: 48, Matched by: org.junit.**)
[ERROR] 		org.junit.rules.TemporaryFolder       	(Line: 49, Matched by: org.junit.**)

What changes are included in this PR?

Fixing the banned imports.

Are these changes tested?

Yes, tests passed.

Are there any user-facing changes?

No.

@abstractdog

Copy link
Copy Markdown
Contributor Author

cc @arouel , @Fokko: as far as I can see this got broken today

@Fokko Fokko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abstractdog I forgot about the banned imports 😨 Thanks for fixing this, appreciate it.

@Fokko
Fokko merged commit a363f5d into apache:master Sep 4, 2026
5 checks passed
@abstractdog

Copy link
Copy Markdown
Contributor Author

@abstractdog I forgot about the banned imports 😨 Thanks for fixing this, appreciate it.

sure, happy to help here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants