Add parameter to enable reading KMS URL from key material - #3745
Open
ggershinsky wants to merge 4 commits into
Open
Add parameter to enable reading KMS URL from key material#3745ggershinsky wants to merge 4 commits into
ggershinsky wants to merge 4 commits into
Conversation
wgtmac
reviewed
Aug 25, 2026
| if (null == kmsInstanceURL) { | ||
| throw new ParquetCryptoRuntimeException( | ||
| "KMS instance URL is missing both in properties and file key material"); | ||
| kmsInstanceURL = KmsClient.KMS_INSTANCE_URL_DEFAULT; |
Member
There was a problem hiding this comment.
Why do we need to change this line?
Contributor
Author
There was a problem hiding this comment.
This will prevent throwing an exception for most of the current users. Today, this exception is never thrown in practice, because the writer always fills the url value (set or default) in the key material, so the reader always gets something, either from properties or from the key material. Now that we skip reading the url from key material by default, the existing readers that don't use the property value, will get an exception. So to prevent it and to preserve the current interface, we drop the exception, and return the KMS_INSTANCE_URL_DEFAULT value (which is given to the readers today, from the key material).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.