MINOR: Preserve ByteBuffer order in little-endian reads - #3702
Open
fallintoplace wants to merge 1 commit into
Open
MINOR: Preserve ByteBuffer order in little-endian reads#3702fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
divjotarora
suggested changes
Aug 25, 2026
divjotarora
left a comment
divjotarora
left a comment
Contributor
There was a problem hiding this comment.
Nice catch! Seems this is a tricky area of the code, several other bugs due to not calling duplicate() were recently fixed 😬
| } | ||
|
|
||
| return value.order(ByteOrder.LITTLE_ENDIAN).getShort(offset); | ||
| return value.duplicate().order(ByteOrder.LITTLE_ENDIAN).getShort(offset); |
Contributor
There was a problem hiding this comment.
Can we do something similar as ByteArraySliceBackedBinary and avoid duplicating?
return (short) (((value.get(offset + 1) & 0xff) << 8) | (value.get(offset) & 0xff));
fallintoplace
force-pushed
the
fix-binary-little-endian-buffer-order
branch
from
August 25, 2026 21:45
f0b0cb8 to
9e70166
Compare
divjotarora
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
ByteBufferBackedBinary.get2BytesLittleEndian()currently changes the byte order of its backingByteBufferto little endian. Because the buffer can be caller-owned, reading the binary can unexpectedly affect subsequent reads through the original buffer.What changes are included in this PR?
Read the short through a duplicate buffer so the original buffer order remains unchanged.
Are these changes tested?
Yes. The regression test verifies the returned value and preserves the original big-endian order for heap, direct, and read-only buffers. The complete
TestBinaryclass and Spotless check pass.Are there any user-facing changes?
Calling
get2BytesLittleEndian()no longer changes the order of the caller-owned backing buffer.