[format] Validate ORC stripe metadata before reading - #9828
Merged
Merged
Conversation
JingsongLi
reviewed
Sep 15, 2026
JingsongLi
left a comment
Contributor
There was a problem hiding this comment.
Requirement fit: SUPPORTED. Implementation: CLEAN.
Reviewed e850bb151966. The validation is on the actual ORC stripe-read path, before the footer read/allocation. Rejecting negative, overflowing and out-of-file metadata has practical failure-containment value. The checks are consistent with the upstream ORC-2200 change (apache/orc#2683).
Validation: compiled the changed Java code against cached dependencies and ran RecordReaderImplTest (2 passed). Current head CI is green. A malformed-file round trip through Paimon was not run locally.
No actionable implementation regression found in this review.
XiaoHongbo-Hope
pushed a commit
that referenced
this pull request
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Tests