[lumina] Validate lumina.encoding.pq.m is positive - #9823
Open
jackylee-ch wants to merge 1 commit into
Open
jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
capPqM's Javadoc requirespq.mto be> 0 && <= dimension; the body checked only the upper bound, solumina.encoding.pq.m = 0reached the native trainer instead of failing here. Javadoc and clamp both arrived in410e1267b(#7330), so the two bounds were never deliberately different — the upper one keeps clamping because tightening it would break tables that build today.Open question
If the native trainer reads
pq.m = 0as "auto", such indexes exist, and sincetoLuminaOptions()is also on the read path (LuminaVectorGlobalIndexReader:253,:377) this would fail their searches too.lumina-jniis external; can anyone confirm?Tests
LuminaVectorOptionsTest#testEncodingPqMBounds(capPqMhad no coverage). Reverting the fix:Written with Claude Code; verification is mine.