[vortex] Do not push nanosecond timestamp literals that overflow int64 - #9810
Open
jackylee-ch wants to merge 1 commit into
Open
jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
For
TIMESTAMP(7..9),toTimestampLiteralcomputests.getMillisecond() * 1_000_000 + ts.getNanoOfMillisecond(). ATIMESTAMPreaches year 9999, so a literal outside roughly[1677-09-21, 2262-04-11]overflows int64:9999-12-31 00:00:00, a common open upper bound, becomes-4852202631933722624ns — year 1816.A wrapped bound turns
>/>=into a superset the post-scan filter repairs, so only<,<=and=silently lose rows — hence unnoticed.#9675 added the grain checks just above; this extends the same refuse-to-push contract to representability, returning
nullso the caller drops the leaf.Tests
VortexPredicateConverterTest#testTimestampNanosOverflowingLiteralNotPushed. Reverting the fix:Written with Claude Code; verification is mine.