Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Removed symbols have no remaining references, and both modified dashboards remain valid JSON.
Review effort: Balanced
Findings: None
What changed in this PR
Removes unused OM metrics and their obsolete dashboard references.
Changes:
- Removes unmodified S3, access-check, and trash counters.
- Removes the obsolete S3 bucket panel and updates dashboard text/layout.
| File | Description |
|---|---|
OMMetrics.java |
Removes unused counters and methods. |
Ozone - Overall Metrics.json |
Removes obsolete panel and closes the layout gap. |
Ozone - OM Overview.json |
Removes outdated metric commentary. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
chihsuan
marked this pull request as ready for review
October 6, 2026 13:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed?
Removes 12 OMMetrics counters that are never updated: S3 bucket metrics, volume check access metrics, and unused trash metrics. Also removes their Grafana dashboard references.
These metrics will no longer be exported through
/promor JMX. Custom dashboards and alerts referencing them will need updating.This cleanup is separate from #11410, as requested in its review.
JIRA
https://issues.apache.org/jira/browse/HDDS-16726
How was this patch tested?
CI: https://github.com/chihsuan/ozone/actions/runs/37472390734
Generated-by: Claude Code (Claude Opus 5.5)