HDDS-16365. Pipeline.getReplicaIndexes() unnecessarily create a new map. - #11194
Open
szetszwo wants to merge 1 commit into
Open
HDDS-16365. Pipeline.getReplicaIndexes() unnecessarily create a new map.#11194szetszwo wants to merge 1 commit into
szetszwo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In Pipeline, the getReplicaIndexes() method, which copies the replicaIndexes map, is not really needed:
For #1 above, getReplicaIndexes() is mainly used for building DatanodeBlockID protos. We will also refactor the code:
What is the link to the Apache JIRA
HDDS-16365
How was this patch tested?
By updating existing tests.