HDDS-16374. Use the datanode-specific block deletion interval during reconfiguration - #11193
Open
shuan1026 wants to merge 2 commits into
Open
HDDS-16374. Use the datanode-specific block deletion interval during reconfiguration#11193shuan1026 wants to merge 2 commits into
shuan1026 wants to merge 2 commits into
Conversation
…erent interval key than startup
…nfiguration Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
shuan1026
marked this pull request as ready for review
September 2, 2026 16:26
chihsuan
approved these changes
Sep 4, 2026
chihsuan
left a comment
chihsuan
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this! @shuan1026 The change looks good to me.
I noticed that apache/ozone-site still lists the old key, so it may be worth creating a follow-up for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Datanode
BlockDeletingServicestarts fromhdds.datanode.block.deleting.service.interval, butupdateAndRestartrereadozone.block.deleting.service.interval(OM's key). HDDS-11513 wired the reconfig path to the shared key after HDDS-4367 had split them. Details are on the Jira.This patch uses the datanode-specific key on every path:
hdds.datanode.block.deleting.service.intervalasreconfigurable = trueand register it viaregister(dnConf).updateAndRestartreadsDatanodeConfiguration.getBlockDeletionInterval()in milliseconds, same as startup.ozone.block.deleting.service.interval. Timeout / workers and OM's shared key are unchanged.Reconfigurability.mdis updated to match the change.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16374
How was this patch tested?
TestBlockDeletingService(including newtestUpdateAndRestartUsesDatanodeInterval): pass. Restoring the old key read fails withexpected: <300000> but was: <60000>.