HDDS-16372. Surface OM's detailed message for rejected lifecycle configuration - #11189
Open
priyeshkaratha wants to merge 1 commit into
Open
HDDS-16372. Surface OM's detailed message for rejected lifecycle configuration#11189priyeshkaratha wants to merge 1 commit into
priyeshkaratha wants to merge 1 commit into
Conversation
priyeshkaratha
marked this pull request as ready for review
September 2, 2026 10:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
PutBucketLifecycleConfigurationwas returning only the generic "Invalid Request" message for any lifecycle configuration rejected by OM — for example, a lifecycle rule with anExpiration.Datein the past — with no indication of why the request was rejected.BucketLifecycleHandler.putBucketLifecycleConfiguration()catchesOMExceptionfrom both the client-side rule validation and theozoneBucket.setLifecycleConfiguration(...)RPC call, and rethrows it as anOS3ExceptionviaS3ErrorTable.newError(...). However,OS3Exception's constructor always setserrorMessageto the static genericS3ErrorTabletext and never copies the underlying cause's message, so OM's specific validation detail (e.g. "Invalid lifecycle configuration: 'Date' must be in the future ...") never reached the client.This chains
.withMessage(ex.getMessage())onto theOS3Exceptionat all threeS3ErrorTable.newError(...)call sites inputBucketLifecycleConfiguration(), matching the existing pattern already used inMessageUnmarshallerandCompleteMultipartUploadRequestUnmarshallerfor the same purpose.What is the link to the Apache JIRA
HDDS-16372
How was this patch tested?
Tested using added test cases.