HDDS-14337. Fix SCM startup failure near year boundary when seeding localId. - #11184
Draft
SaketaChalamchala wants to merge 1 commit into
Draft
HDDS-14337. Fix SCM startup failure near year boundary when seeding localId.#11184SaketaChalamchala wants to merge 1 commit into
SaketaChalamchala wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SCM can fail to start when it is first deployed near a year boundary (e.g. Dec 31). During the one-time migration to
SequenceIdGenerator, SCM seeds an initiallocalIdand requires it to be strictly greater than any ID the legacyUniqueIdgenerator could have produced.The seed was computed using
LocalDate.of(LocalDate.now(ZoneOffset.UTC).getYear() + 1, 1, 1).toEpochDay())(JVM local timezone), whileUniqueId.next()usesSystem.currentTimeMillis()(UTC).Near year boundaries these can disagree — for example, Dec 31 evening in US timezones while UTC is already Jan 1 — causing
Preconditions.checkArgument(localId > UniqueId.next())to fail and SCM startup to abort.This proposed change computes the initial
localIdfrom the UTC calendar year as well.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14337
How was this patch tested?
Unit Test.